perf: Use specialized decoding for all predicates for Parquet dictionary encoding (#24403)

Author: coastalwhite

crates/polars-parquet/src/arrow/read/deserialize/binview/mod.rs

@@ -496,7 +496,7 @@ impl utils::Decoder for BinViewDecoder {
     fn evaluate_predicate(
         &mut self,
         state: &utils::State<'_, Self>,
-        predicate: &SpecializedParquetColumnExpr,
+        predicate: Option<&SpecializedParquetColumnExpr>,
         pred_true_mask: &mut BitmapBuilder,
         dict_mask: Option<&Bitmap>,
     ) -> ParquetResult<bool> {
@@ -515,6 +515,10 @@ impl utils::Decoder for BinViewDecoder {
             return Ok(true);
         }
 
+        let Some(predicate) = predicate else {
+            return Ok(false);
+        };
+
         use {SpecializedParquetColumnExpr as Spce, StateTranslation as St};
         match (&state.translation, predicate) {
             (St::Plain(iter), Spce::Equal(needle)) => {

crates/polars-parquet/src/arrow/read/deserialize/boolean.rs

@@ -330,7 +330,7 @@ impl Decoder for BooleanDecoder {
     fn evaluate_predicate(
         &mut self,
         _state: &utils::State<'_, Self>,
-        _predicate: &SpecializedParquetColumnExpr,
+        _predicate: Option<&SpecializedParquetColumnExpr>,
         _pred_true_mask: &mut BitmapBuilder,
         _dict_mask: Option<&Bitmap>,
     ) -> ParquetResult<bool> {

crates/polars-parquet/src/arrow/read/deserialize/categorical.rs

@@ -79,7 +79,7 @@ impl<T: DictionaryKey + IndexMapping<Output = T::AlignedBytes>> utils::Decoder
     fn evaluate_predicate(
         &mut self,
         state: &utils::State<'_, Self>,
-        _predicate: &SpecializedParquetColumnExpr,
+        _predicate: Option<&SpecializedParquetColumnExpr>,
         pred_true_mask: &mut BitmapBuilder,
         dict_mask: Option<&Bitmap>,
     ) -> ParquetResult<bool> {

crates/polars-parquet/src/arrow/read/deserialize/fixed_size_binary.rs

@@ -548,7 +548,7 @@ impl Decoder for BinaryDecoder {
     fn evaluate_predicate(
         &mut self,
         _state: &utils::State<'_, Self>,
-        _predicate: &SpecializedParquetColumnExpr,
+        _predicate: Option<&SpecializedParquetColumnExpr>,
         _pred_true_mask: &mut BitmapBuilder,
         _dict_mask: Option<&Bitmap>,
     ) -> ParquetResult<bool> {

crates/polars-parquet/src/arrow/read/deserialize/null.rs

@@ -73,7 +73,7 @@ impl utils::Decoder for NullDecoder {
     fn evaluate_predicate(
         &mut self,
         _state: &utils::State<'_, Self>,
-        _predicate: &SpecializedParquetColumnExpr,
+        _predicate: Option<&SpecializedParquetColumnExpr>,
         _pred_true_mask: &mut BitmapBuilder,
         _dict_mask: Option<&Bitmap>,
     ) -> ParquetResult<bool> {

crates/polars-parquet/src/arrow/read/deserialize/primitive/float.rs

@@ -164,7 +164,7 @@ where
     fn evaluate_predicate(
         &mut self,
         state: &utils::State<'_, Self>,
-        _predicate: &SpecializedParquetColumnExpr,
+        _predicate: Option<&SpecializedParquetColumnExpr>,
         pred_true_mask: &mut BitmapBuilder,
         dict_mask: Option<&Bitmap>,
     ) -> ParquetResult<bool> {

crates/polars-parquet/src/arrow/read/deserialize/primitive/integer.rs

@@ -193,10 +193,15 @@ where
     fn evaluate_predicate(
         &mut self,
         state: &utils::State<'_, Self>,
-        predicate: &SpecializedParquetColumnExpr,
+        predicate: Option<&SpecializedParquetColumnExpr>,
         pred_true_mask: &mut BitmapBuilder,
         dict_mask: Option<&Bitmap>,
     ) -> ParquetResult<bool> {
+        // @Performance: This should be added
+        if state.page_validity.is_some() {
+            return Ok(false);
+        }
+
         if let StateTranslation::Dictionary(values) = &state.translation {
             let dict_mask = dict_mask.unwrap();
             super::super::dictionary_encoded::predicate::decode(
@@ -211,10 +216,9 @@ where
             return Ok(false);
         }
 
-        // @Performance: This should be added
-        if state.page_validity.is_some() {
+        let Some(predicate) = predicate else {
             return Ok(false);
-        }
+        };
 
         use SpecializedParquetColumnExpr as S;
         match (&state.translation, predicate) {

crates/polars-parquet/src/arrow/read/deserialize/utils/mod.rs

@@ -319,7 +319,7 @@ pub(super) trait Decoder: Sized {
     fn evaluate_predicate(
         &mut self,
         state: &State<'_, Self>,
-        predicate: &SpecializedParquetColumnExpr,
+        predicate: Option<&SpecializedParquetColumnExpr>,
         pred_true_mask: &mut BitmapBuilder,
         dict_mask: Option<&Bitmap>,
     ) -> ParquetResult<bool>;
@@ -613,14 +613,12 @@ impl<D: Decoder> PageDecoder<D> {
                 // handled in the kernels. If it cannot be handled in the kernels, catch it here
                 // and load it as if it weren't filtered.
                 let mut page_ptm = BitmapBuilder::new();
-                if let Some(specialized_pred) = specialized_pred
-                    && self.decoder.evaluate_predicate(
-                        &state,
-                        specialized_pred,
-                        &mut page_ptm,
-                        dict_mask.as_ref(),
-                    )?
-                {
+                if self.decoder.evaluate_predicate(
+                    &state,
+                    specialized_pred,
+                    &mut page_ptm,
+                    dict_mask.as_ref(),
+                )? {
                     let num_filtered_values = page_ptm.set_bits();
                     if page_ptm.set_bits() == 0 {
                         pred_true_mask.extend_constant(page_ptm.len(), false);
@@ -652,7 +650,8 @@ impl<D: Decoder> PageDecoder<D> {
                     pred_true_mask.extend_from_bitmap(&page_ptm);
 
                     if p.include_values {
-                        if let SpecializedParquetColumnExpr::Equal(needle) = specialized_pred {
+                        if let Some(SpecializedParquetColumnExpr::Equal(needle)) = specialized_pred
+                        {
                             self.decoder.extend_constant(
                                 &mut target,
                                 num_filtered_values,