Fix Windows support, expand GHA platform coverage (#51)

* Add Windows job to GitHub Actions workflow

* Update ci.yml

* Remove unused `cLocale` breaking the Windows build

* Exclude benchmark product from Windows builds

* Try using forked swift-benchmark

* Build and test on Ubuntu

* Switch to upstream `swift-benchmark` dependency

* Use `MaxDesiatov/swift-windows-action`

* Bump `swift-benchmark` to 0.1.1

* Reduce `Package.swift` diff

* Remove redundant whitespace

* Request `macos-11` GHA agents explicitly

* Test with multiple Swift versions on macOS

* Quote Xcode versions because YAML is awful

Author: MaxDesiatov

.github/workflows/ci.yml

@@ -9,13 +9,15 @@ on:
       - '*'
 
 jobs:
-  tests:
-    runs-on: macOS-latest
+  macos_tests:
+    runs-on: macos-11
     strategy:
       matrix:
         xcode:
-          - 11.7
-          - 12.3
+          - "11.7" # Latest Xcode with Swift 5.2
+          - "12.4" # Swift 5.3
+          - "12.5" # Swift 5.4
+          - "13.0" # Swift 5.5
         command:
           - test
           - benchmarks
@@ -27,3 +29,24 @@ jobs:
         run: system_profiler SPHardwareDataType
       - name: Run ${{ matrix.command }}
         run: make ${{ matrix.command }}
+
+  ubuntu_tests:
+    strategy:
+      matrix:
+        os: [ubuntu-18.04, ubuntu-20.04]
+
+    runs-on: ${{ matrix.os }}
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Build
+        run: swift build
+      - name: Run tests
+        run: swift test
+
+  windows_tests:
+    runs-on: windows-2019
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: MaxDesiatov/swift-windows-action@v1

Package.resolved

@@ -6,17 +6,17 @@
         "repositoryURL": "https://github.com/apple/swift-argument-parser",
         "state": {
           "branch": null,
-          "revision": "92646c0cdbaca076c8d3d0207891785b3379cbff",
-          "version": "0.3.1"
+          "revision": "6b2aa2748a7881eebb9f84fb10c01293e15b52ca",
+          "version": "0.5.0"
         }
       },
       {
         "package": "Benchmark",
         "repositoryURL": "https://github.com/google/swift-benchmark",
         "state": {
           "branch": null,
-          "revision": "8e0ef8bb7482ab97dcd2cd1d6855bd38921c345d",
-          "version": "0.1.0"
+          "revision": "a0564bf88df5f94eec81348a2f089494c6b28d80",
+          "version": "0.1.1"
         }
       }
     ]

Package.swift

@@ -11,7 +11,7 @@ let package = Package(
     )
   ],
   dependencies: [
-    .package(name: "Benchmark", url: "https://github.com/google/swift-benchmark", from: "0.1.0")
+    .package(name: "Benchmark", url: "https://github.com/google/swift-benchmark", from: "0.1.1")
   ],
   targets: [
     .target(

Sources/Parsing/Parsers/Double.swift

@@ -290,11 +290,3 @@ extension Collection where SubSequence == Self, Element == UTF8.CodeUnit {
     return original[..<self.startIndex]
   }
 }
-
-#if os(Windows)
-  @usableFromInline
-  let cLocale: locale_t? = _create_locale(LC_ALL, "C")
-#else
-  @usableFromInline
-  let cLocale: locale_t? = nil
-#endif