Properly tag observable enums #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Feb 8, 2024
| private var storage: Storage | ||
|
|
||
| @usableFromInline |
There was a problem hiding this comment.
Losing the inlinability here, but think it's fine.
stephencelis
commented
Feb 8, 2024
| @@ -72,9 +62,8 @@ | |||
|
|
|||
| public static let _$inert = Self() | |||
|
|
|||
| @inlinable | |||
There was a problem hiding this comment.
Losing the inlinability here, but think it's fine.
stephencelis
commented
Feb 8, 2024
| @inlinable | ||
| public func _$tag(_ tag: Int?) -> Self { | ||
| Self(location: self.location, tag: tag) | ||
| public func _$tag(_ tag: Int) -> Self { |
There was a problem hiding this comment.
Slight API change here, but couldn't find an instance where nil was being passed.
mbrandonw
approved these changes
Feb 8, 2024
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Feb 13, 2024
…ure to from: "1.8.0" (#914) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture) | minor | `from: "1.7.3"` -> `from: "1.8.0"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.8.0`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.8.0) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.7.3...1.8.0) #### What's Changed - Added: New `@Reducer` macro features ([https://github.com/pointfreeco/swift-composable-architecture/pull/2795](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2795)). The `@Reducer` macro has been enhanced to streamline usage and simplify some common patterns: - When left undefined, the `@Reducer` will now define default implementations of `State`, `Action`, and `body`. This means stubbing a feature is as simple as `@Reducer struct Feature {}`. - `@Reducer` can now be used with enums to simplify the boilerplate associated with "destination" and "path" reducers. See the [1.8 migration guide](https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.8) for more information on how to use these APIs. - Fixed: Propagate `@ViewAction` macro availability ([https://github.com/pointfreeco/swift-composable-architecture/pull/2785](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2785)). - Fixed: Properly tag nested observable enums so that changes to non-observable cases are better observed ([https://github.com/pointfreeco/swift-composable-architecture/pull/2786](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2786)). - Infrastructure: Fix typo in migration guide 1.6 (thanks [@​takehilo](https://togithub.com/takehilo), [https://github.com/pointfreeco/swift-composable-architecture/pull/2779](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2779)); better document explicit `id` with scoped `ForEach` ([https://github.com/pointfreeco/swift-composable-architecture/pull/2784](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2784)); Fix typo in the 1.7 migration guide (thanks [@​yaslab](https://togithub.com/yaslab), [https://github.com/pointfreeco/swift-composable-architecture/pull/2780](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2780); thanks [@​Ryu0118](https://togithub.com/Ryu0118), [https://github.com/pointfreeco/swift-composable-architecture/pull/2790](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2790)); **Full Changelog**: pointfreeco/swift-composable-architecture@1.7.2...1.8.0 #### New Contributors - [@​yaslab](https://togithub.com/yaslab) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2780](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2780) **Full Changelog**: pointfreeco/swift-composable-architecture@1.7.3...1.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for nested, inert enums to have the same "tag" and thus identity when they are distinct structures, which prevents cases changes from being observed. Let's allow tagging to happen recursively, which will allow for distinct identity in these cases.