Short-circuit the store cache from uncached stores #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Dec 1, 2023
stephencelis
commented
Dec 1, 2023
Comment on lines
+40
to
+45
| childStore.send(.tap) | ||
| XCTAssertEqual(3, grandparentStore.withState(\.child.child.count)) | ||
| XCTAssertEqual(3, childStore.withState(\.count)) | ||
| grandparentStore.send(.incrementGrandchild) | ||
| XCTAssertEqual(4, grandparentStore.withState(\.child.child.count)) | ||
| XCTAssertEqual(4, childStore.withState(\.count)) |
There was a problem hiding this comment.
Both childStore assertions fail on 1.5.0...main.
mbrandonw
approved these changes
Dec 2, 2023
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Dec 5, 2023
…ure to from: "1.5.1" (#782) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture) | patch | `from: "1.5.0"` -> `from: "1.5.1"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.5.1`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.5.1) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.5.0...1.5.1) #### What's Changed - Fixed: `BindingAction`'s case key path extraction was broken, which could lead to actions received through effects to not be testable, *.e.g* `\.binding.$text` would fail to match `.binding(.set(\.$text, "Blob"))`. This has been fixed ([https://github.com/pointfreeco/swift-composable-architecture/pull/2600](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2600)). - Fixed: Store caching introduced in 1.5 could lead to a regression in which a child store becomes "detached" when an uncached parent is deinitialized. This has been fixed by only caching child stores when its parents are cached ([https://github.com/pointfreeco/swift-composable-architecture/pull/2605](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2605)). - Fixed: `NavigationStackStore`'s internal use of `@StateObject` could lead to broken navigation. By using an `@ObservedObject` instead we now avoid this bug ([https://github.com/pointfreeco/swift-composable-architecture/pull/2599](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2599)). - Infrastructure: Fixed typo in 1.5 migration guide (thanks [@​Ryu0118](https://togithub.com/Ryu0118), [https://github.com/pointfreeco/swift-composable-architecture/pull/2595](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2595); thanks [@​yimajo](https://togithub.com/yimajo), [https://github.com/pointfreeco/swift-composable-architecture/pull/2606](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2606)); update documentation links in README (thanks [@​woxtu](https://togithub.com/woxtu), [https://github.com/pointfreeco/swift-composable-architecture/pull/2598](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2598)); **Full Changelog**: pointfreeco/swift-composable-architecture@1.5.0...1.5.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.5 introduced the store tree, which works well when the entire tree is cached, but can produce invalid stores when an uncached store caches a child store and is then reinitialized. While folks upgrading to 1.5 should be in a good state, adopting the new
scopeoperator can introduce this problem. To mitigate, we should only cache from the root to nodes as far as the cache resolves.This is a temporary limitation to avoid breaking existing apps. We should be able to remove this workaround when uncached scopes are fully deprecated and removed from the library.