From 190eddd4c017c0da5d6c8206a015419d77ac395c Mon Sep 17 00:00:00 2001 From: Trygve Lie Date: Fri, 8 Dec 2023 00:08:28 +0100 Subject: [PATCH 1/2] fix: Pass podlet name to proxy --- lib/podlet.js | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/podlet.js b/lib/podlet.js index f8339705..a48483b8 100644 --- a/lib/podlet.js +++ b/lib/podlet.js @@ -684,7 +684,7 @@ export default class PodiumPodlet { if (this.development) { // @ts-ignore - this.httpProxy.register(this.toJSON()); + this.httpProxy.register(this.name, this.toJSON()); } return target; diff --git a/package.json b/package.json index ffda6ae1..9f3437fa 100644 --- a/package.json +++ b/package.json @@ -31,7 +31,7 @@ }, "dependencies": { "@metrics/client": "2.5.2", - "@podium/proxy": "5.0.0", + "@podium/proxy": "5.0.2", "@podium/schemas": "5.0.0", "@podium/utils": "5.0.0", "abslog": "2.4.0", From fa16158af455cdb1db99cc7ca462d42af10f9bcb Mon Sep 17 00:00:00 2001 From: Richard Walker Date: Fri, 8 Dec 2023 12:32:04 +1300 Subject: [PATCH 2/2] chore(types): something changed such that .default needed to be included --- lib/podlet.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/podlet.js b/lib/podlet.js index a48483b8..d104f802 100644 --- a/lib/podlet.js +++ b/lib/podlet.js @@ -47,7 +47,7 @@ const { template } = utils; * @property {string} [fallback] - path where the podlet fallback HTML markup is served from (default '/fallback') * @property {boolean} [development] - a boolean flag that, when true, enables additional development setup (default false) * @property {Console | AbsLogger} [logger] - a logger to use when provided. Can be the console object if console logging is desired but can also be any Log4j compatible logging object as well. Nothing is logged if no logger is provided. (default null) - * @property {import("@podium/proxy").PodiumProxyOptions} proxy - options that can be provided to configure the @podium/proxy instance used by the podlet. See that module for details. + * @property {import("@podium/proxy").default.PodiumProxyOptions} proxy - options that can be provided to configure the @podium/proxy instance used by the podlet. See that module for details. * * @typedef {{ debug: 'true' | 'false', locale: string, deviceType: string, requestedBy: string, mountOrigin: string, mountPathname: string, publicPathname: string }} PodletContext * @typedef {{ as?: string | false | null, crossorigin?: string | null | boolean, disabled?: boolean | '' | null, hreflang?: string | false | null, title?: string | false | null, media?: string | false | null, rel?: string | false | null, type?: string | false | null, value: string | false | null, data?: Array<{ key: string; value: string }>, strategy?: "beforeInteractive" | "afterInteractive" | "lazy", scope?: "content" | "fallback" | "all", [key: string]: any }} AssetCssLike