Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store parameters of crowdsales in a local file for Invest page #133

Closed
igorbarinov opened this issue Sep 9, 2017 · 3 comments
Closed

Store parameters of crowdsales in a local file for Invest page #133

igorbarinov opened this issue Sep 9, 2017 · 3 comments

Comments

@igorbarinov
Copy link
Member

An attacker can send a user to a legit website with a fraudulent contract. Crowdsale addresses now in GET parameters in URL and it's easy to commit fraud for the attacker.

One solution to mitigate the problem is to store parameters of the crowdsale in a configuration file. I propose to store them in local structure of an instance of ICO Wizard, e.g. using this technique https://stackoverflow.com/questions/37066758/how-can-i-use-a-config-file-in-react

If a file with config is present, the app should use parameters from the file even GET parameters are used.

After implementation of the feature add a section about configuration to README.md file

@vbaranov
Copy link
Collaborator

I believe, this local structure will work for user, who created the instance of ICO.
But we can't transfer it to any investor by client-side.
will looking for another solution.

@igorbarinov
Copy link
Member Author

Yes, this is how it is planned. If you want to use this feature you have to deploy on your instance.
One instance = one crowdsale.

@vbaranov
Copy link
Collaborator

@igorbarinov Ah, ok. And owner of the instance will manually change this config after crowdsale creation. Will implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants