Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistranslation in Japanese #545

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Fix mistranslation in Japanese #545

merged 1 commit into from
Apr 29, 2020

Conversation

karamem0
Copy link
Contributor

Q A
Bug fix? [x]
New feature? []
New sample? []
Related issues?

What's in this Pull Request?

This PR fixes some of mistranslation in Japanese.

@msftclas
Copy link

msftclas commented Apr 27, 2020

CLA assistant check
All CLA requirements met.

@AJIXuMuK
Copy link
Collaborator

Hi @karamem0!
Thank you for fixing the translation!

I have one concern though: you've removed {1} placeholder from ListItemAttachmentsfileDeleteError. In that case reason of the error will not be displayed.
Is that intended or done by mistake?

Thanks!

@karamem0
Copy link
Contributor Author

Hi @AJIXuMuK,
It's probably a mistake. Correct is:
ファイルの削除中にエラーが発生しました: {0}。原因: {1}

@AJIXuMuK AJIXuMuK merged commit 92b8f1d into pnp:dev Apr 29, 2020
@AJIXuMuK
Copy link
Collaborator

Thank you @karamem0!
The PR has been merged and will be included in the next release.

@AJIXuMuK AJIXuMuK added this to the 1.18.0 milestone Apr 29, 2020
@estruyf estruyf mentioned this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants