Fix: comboBoxListItemPicker onSelectedItem callback fix #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h import in listview
|
thanks @gautamdsheth for the fix and sharing the credit :) |
|
Thank you @gautamdsheth and @siddharth-vaghasia! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
This PR fixes issues #519 related to comboBoxListItemPicker callback.
Also, there is an issue when
multiselectis set to false or not set at all, the correct value was not returned, check the comment in the mentioned issue. It has been fixed as well.Also added a minor fix, corrected the lodash import in listview control.
Thanks to @siddharth-vaghasia for suggesting the fix, have incorporated his comment in the fix.
Happy to share the credit with him.