Skip to content

Dispose of Async instance to prevent memory leak #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

KevinTCoughlin
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Disposes of Async instance so it can be garbage collected.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the first contribution to this project.

@AJIXuMuK AJIXuMuK changed the base branch from master to dev March 1, 2025 18:06
@KevinTCoughlin KevinTCoughlin requested a review from AJIXuMuK March 1, 2025 18:57
@KevinTCoughlin KevinTCoughlin force-pushed the user/keco/functional-async-dispose branch from fb548c7 to aa321c4 Compare March 1, 2025 19:05
@AJIXuMuK AJIXuMuK merged commit 91a4b7b into pnp:dev Mar 3, 2025
1 check passed
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Mar 3, 2025

Thank you @KevinTCoughlin for the change!

@AJIXuMuK AJIXuMuK added this to the 3.21.0 milestone Mar 3, 2025
@michaelmaillot michaelmaillot mentioned this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants