Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaxonomyPicker suggestions language #879

Closed
janijaak opened this issue Apr 16, 2021 · 3 comments
Closed

TaxonomyPicker suggestions language #879

janijaak opened this issue Apr 16, 2021 · 3 comments
Labels
status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@janijaak
Copy link

Category

[x] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [2.6.0]

Expected / Desired Behavior

Currently TaxonomyPicker suggestions language is always english/term store default language. It should always be the same as in the picker which seems to respect users selected language.

Observed Behavior

I'm using TaxonomyPicker in my form and when I start writing the term to the control I have to use English. When I select the term from picker the terms are shown in my users language which is Finnish.

In the picture you can also see that when the term was picked by writing in the TaxonomyPicker I had to use English. After that when I open the picker the term is in Finnish and also selected.

TaxonomyPicker

@ghost
Copy link

ghost commented Apr 16, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Apr 16, 2021
@joelfmrodrigues joelfmrodrigues added help wanted type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels May 7, 2021
@joelfmrodrigues
Copy link
Collaborator

@janijaak thanks for the suggestion. Would you be interested in implementing this change and submitting a PR?

@petkir petkir mentioned this issue Jul 5, 2021
@petkir
Copy link
Contributor

petkir commented Jul 5, 2021

Hi @janijaak , Hi @joelfmrodrigues

in PR #950 it is with an additional property solved useUserLanguage?:boolean, but I think @janijaak enhancement should be the default behavior.

What do you think about changing to user UI language by default?

v1 and v2 are waiting for your response.

@AJIXuMuK AJIXuMuK added this to the 3.4.0 milestone Sep 2, 2021
@AJIXuMuK AJIXuMuK added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. and removed help wanted labels Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

4 participants