Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFrameDialog height unable to resize relative to screen size, even if we provide in % it is taking default value. #636

Closed
raghuram753 opened this issue Aug 20, 2020 · 3 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@raghuram753
Copy link

raghuram753 commented Aug 20, 2020

Below is the code I am using:

{this.state.showSiteUsersModal ?
<IFrameDialog
url={this.state.siteAddress}
onDismiss={this.closeSiteUsers}
hidden={!this.state.showSiteUsersModal}
modalProps={{
isBlocking: true
}}
dialogContentProps={{
showCloseButton: true,
type: DialogType.close,
}}
allowFullScreen={true}
allowTransparency={true}
width={'60%'}
height={'50%'}/>
: null }

width is getting auto adjusted relative to device, where as height is not getting adjusted with respective device.

Attached the screenshot, what ever the height we specify it is of same height.

IFrameHeight

@ghost
Copy link

ghost commented Aug 20, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@AJIXuMuK
Copy link
Collaborator

Hi @raghuram753,

The fix has been merged and will be included in the next release.

In a meanwhile you can test the functionality in beta version.

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Feb 16, 2021
@AJIXuMuK AJIXuMuK added this to the 2.5.0 milestone Feb 16, 2021
@estruyf estruyf mentioned this issue Mar 2, 2021
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Mar 2, 2021

v2.5.0 has been released.

@AJIXuMuK AJIXuMuK closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

2 participants