Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comboboxlistitempicker reload options when filter changes #1180

Closed
russgove opened this issue Apr 5, 2022 · 1 comment · Fixed by #1181 or #1205
Closed

Comboboxlistitempicker reload options when filter changes #1180

russgove opened this issue Apr 5, 2022 · 1 comment · Fixed by #1181 or #1205
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@russgove
Copy link
Contributor

russgove commented Apr 5, 2022

Category

[ ] Enhancement

[x ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ latest ]

_

Expected / Desired Behavior / Question

Comboboboxlistitempicker should refresh options if filter changes

Observed Behavior

Comboboboxlistitempicker should refresh options if filter changes

Steps to Reproduce

Change the filter on a comboboxlistitemfilere at runtime (useful for cascading dropdowns.

I noticed in the code:
public async componentWillReceiveProps(nextProps: IComboBoxListItemPickerProps): Promise {
if (nextProps.listId !== this.props.listId) {
this.setState({
selectedItems: [],
});
await this.loadOptions(nextProps, false);

shouldnt we also call loadOptions if the filter changes?

}
@ghost
Copy link

ghost commented Apr 5, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Apr 5, 2022
@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Apr 23, 2022
@joelfmrodrigues joelfmrodrigues added this to the 3.8.0 milestone Apr 28, 2022
@AJIXuMuK AJIXuMuK mentioned this issue May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
2 participants