Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding color or highlights should add classNames instead of inline styles #1152

Open
mhammadsiddiqui opened this issue Mar 14, 2022 · 3 comments

Comments

@mhammadsiddiqui
Copy link

Category

[ x ] Enhancement

[ ] Bug

[ x ] Question

Version

Please specify what version of the library you are using: [ 3.5.0 ]

Expected / Desired Behavior / Question

If you are reporting an issue please describe the expected behavior. If you are suggesting an enhancement please
describe thoroughly the enhancement, how it can be achieved, and expected benefit. If you are asking a question, ask away!

Observed Behavior

Updating the color and highlights of text will add the inline styles

If we change the text color it will add the inline styles unlike Rich text editor from sharepoint online. So if the Theme look is changed to dark theme, the color is not changing accordingly so sometimes visibility of text becomes almost 0, incase contrast ration is not good.

Is it possible to add classes from office-ui-fabric instead of adding inline colors.

Thanks!

@ghost
Copy link

ghost commented Mar 14, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@joelfmrodrigues
Copy link
Collaborator

@mhammadsiddiqui Thanks for raising this.
Your suggestion sounds like a good improvement, but as it could cause unexpected changes/behaviour to existing implementations after an update, I think we should have a discussion about it first to try to identify any possible issues.

@AJIXuMuK any thoughts on this?

@AJIXuMuK
Copy link
Collaborator

I think it can be done as an optional property.
Default behavior won't change.

But first we need to check if that's feasible (we actually can use classes instead inline styles in the underlying control).
@mhammadsiddiqui - would you be interested in checking/implementing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants