You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please specify what version of the library you are using: [ 3.5.0 ]
Expected / Desired Behavior / Question
If you are reporting an issue please describe the expected behavior. If you are suggesting an enhancement please
describe thoroughly the enhancement, how it can be achieved, and expected benefit. If you are asking a question, ask away!
Observed Behavior
Updating the color and highlights of text will add the inline styles
If we change the text color it will add the inline styles unlike Rich text editor from sharepoint online. So if the Theme look is changed to dark theme, the color is not changing accordingly so sometimes visibility of text becomes almost 0, incase contrast ration is not good.
Is it possible to add classes from office-ui-fabric instead of adding inline colors.
Thanks!
The text was updated successfully, but these errors were encountered:
@mhammadsiddiqui Thanks for raising this.
Your suggestion sounds like a good improvement, but as it could cause unexpected changes/behaviour to existing implementations after an update, I think we should have a discussion about it first to try to identify any possible issues.
I think it can be done as an optional property.
Default behavior won't change.
But first we need to check if that's feasible (we actually can use classes instead inline styles in the underlying control). @mhammadsiddiqui - would you be interested in checking/implementing it?
Category
[ x ] Enhancement
[ ] Bug
[ x ] Question
Version
Please specify what version of the library you are using: [ 3.5.0 ]
Expected / Desired Behavior / Question
If you are reporting an issue please describe the expected behavior. If you are suggesting an enhancement please
describe thoroughly the enhancement, how it can be achieved, and expected benefit. If you are asking a question, ask away!
Observed Behavior
Updating the color and highlights of text will add the inline styles
If we change the text color it will add the inline styles unlike Rich text editor from sharepoint online. So if the Theme look is changed to dark theme, the color is not changing accordingly so sometimes visibility of text becomes almost 0, incase contrast ration is not good.
Is it possible to add classes from office-ui-fabric instead of adding inline colors.
Thanks!
The text was updated successfully, but these errors were encountered: