Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPFx theme & context property to the AdaptiveCardHost control #1145

Closed
fabiofranzini opened this issue Mar 11, 2022 · 4 comments · Fixed by #1205
Closed

Add SPFx theme & context property to the AdaptiveCardHost control #1145

fabiofranzini opened this issue Mar 11, 2022 · 4 comments · Fixed by #1205
Assignees
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@fabiofranzini
Copy link
Collaborator

Category

[X] Enhancement
[-] Bug
[-] Question

Version

Please specify what version of the library you are using: [3.6.0]

Expected

Speaking with @joaojmendes about the possible evolutions of the control, and specifically in the creation of a library of additional elements (using MGT for example), it is necessary to pass the "Theme" object and values that come from the "Context" of SPFx, so to be used with the Adaptive Card "templating" syntax and therefore to be passed to the new elements.

The idea is to directly inject these values into the "Data" object which is then used to do the "binding" in the rendering phase.

An example could be to pass the colors of the theme applied to a template to discriminate which image to load (understand if the theme is dark or not), etc., etc.

Or, thanks to the context of SPFx, you can have information on the site, current user, etc., etc. and use that information as properties in the "data" object

@ghost
Copy link

ghost commented Mar 11, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Mar 11, 2022
@fabiofranzini fabiofranzini changed the title Add SPFx context property to the AdaptiveCardHost control Add SPFx theme & context property to the AdaptiveCardHost control Mar 11, 2022
@joelfmrodrigues
Copy link
Collaborator

@fabiofranzini are you aiming to create a PR for this? If so, I can assign this item to you

@joelfmrodrigues joelfmrodrigues added type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Mar 11, 2022
@fabiofranzini
Copy link
Collaborator Author

@joelfmrodrigues yes! I'll create the PR in 30 mins 😀

@fabiofranzini
Copy link
Collaborator Author

@joelfmrodrigues and @joaojmendes done 😀

@AJIXuMuK AJIXuMuK added the status:fixed-next-drop Issue will be fixed in upcoming release. label Apr 25, 2022
@AJIXuMuK AJIXuMuK added this to the 3.8.0 milestone Apr 25, 2022
@AJIXuMuK AJIXuMuK mentioned this issue May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants