Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW CONTROL - Variant Theme Provider #1120

Closed
fabiofranzini opened this issue Feb 10, 2022 · 2 comments · Fixed by #1157
Closed

NEW CONTROL - Variant Theme Provider #1120

fabiofranzini opened this issue Feb 10, 2022 · 2 comments · Fixed by #1157
Assignees
Labels
type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@fabiofranzini
Copy link
Collaborator

Hi, I'm using in production in several Web Parts a control that I had shown (in its first implementation) in this Web Part: https://github.com/pnp/sp-dev-fx-webparts/blob/main/samples/react-fluentui-theme-variant

In practice it is a React control that allows you to apply the theme variation directly to the Web Part instead of to the entire section of the page.
It therefore allows you to take a Fluent UI theme and apply the required variation among those available in Fluent UI, namely: none, neutral, soft, strong.

Would it be interesting to have it as a react control for this library?

@ghost
Copy link

ghost commented Feb 10, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Feb 10, 2022
@AJIXuMuK
Copy link
Collaborator

Hi @fabiofranzini - it will definitely be interesting!
Already waiting for the PR :)

@AJIXuMuK AJIXuMuK added type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Feb 11, 2022
@AJIXuMuK AJIXuMuK added this to the 3.7.0 milestone Mar 5, 2022
@AJIXuMuK AJIXuMuK mentioned this issue Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants