Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button has the wrong german translation #1059

Closed
sancezz2k opened this issue Nov 11, 2021 · 3 comments
Closed

Save button has the wrong german translation #1059

sancezz2k opened this issue Nov 11, 2021 · 3 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@sancezz2k
Copy link

sancezz2k commented Nov 11, 2021

Category
[ ] Enhancement

[ x] Bug

[ ] Question

Version
3.4.1

Expected / Desired Behavior / Question
I expect the correct German translation for the text of the save button.

Observed Behavior
The German translation for the text of the Save button is wrong. The text should be: 'Speichern' - currently the text is 'Retten'.
Here are the German translations: https://github.com/pnp/sp-dev-fx-controls-react/blob/440c2af2b5750e6ec5e609d0ef254e9524544596/src/loc/de-de.ts

Steps to Reproduce
Set the language of the browser to German and then test e.g. a DynamicForm Webpart.

@ghost
Copy link

ghost commented Nov 11, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Nov 11, 2021
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Nov 27, 2021
@joelfmrodrigues joelfmrodrigues added this to the 3.5.0 milestone Nov 27, 2021
@joelfmrodrigues
Copy link
Collaborator

@sancezz2k many thanks for raising the issue and providing a solution.
The label is now updated and will be included as part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

3 participants