Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<ListPicker> baseTemplate option should allow string or multiple numbers #1016

Closed
Xiyitifu opened this issue Sep 21, 2021 · 3 comments · Fixed by #1050
Closed

<ListPicker> baseTemplate option should allow string or multiple numbers #1016

Xiyitifu opened this issue Sep 21, 2021 · 3 comments · Fixed by #1050
Labels
Good First Issue 🏆 type:enhancement New feature or enhancement of existing capability
Milestone
3.5.0

Comments

@Xiyitifu
Copy link
Contributor

Xiyitifu commented Sep 21, 2021 •
edited
Loading

Category

[x] Enhancement

Version

Please specify what version of the library you are using: [ Latest : 3.3.0]

Expected / Desired Behavior / Question

ListPicker Component should allow input of a string or multiple numbers because filter request is allowing it.
(Example : ?$filter=(BaseTemplate eq 100 or BaseTemplate eq 106))

Observed Behavior

ListPicker actually do not allow other input than number.

Steps to Reproduce

Use ListPicker component and set baseTemplate option.
@ghost
Copy link

ghost commented Sep 21, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Sep 21, 2021
@Xiyitifu Xiyitifu mentioned this issue Sep 22, 2021
Closed
@joelfmrodrigues joelfmrodrigues added Good First Issue 🏆 type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Oct 2, 2021
@joelfmrodrigues
Copy link
Collaborator

@Xiyitifu thanks for this suggestion, definitely a good enhancement.

@Xiyitifu Xiyitifu mentioned this issue Oct 26, 2021
Merged
@joelfmrodrigues
Copy link
Collaborator

Merged and will be included on the next release

@joelfmrodrigues joelfmrodrigues added this to the 3.5.0 milestone Nov 18, 2021
@estruyf estruyf mentioned this issue Dec 3, 2021
Merged
@AJIXuMuK AJIXuMuK closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue 🏆 type:enhancement New feature or enhancement of existing capability
Projects
None yet
Milestone
3.5.0
3 participants
@AJIXuMuK @joelfmrodrigues @Xiyitifu