Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Pages #1

Open
charliepnnl opened this issue May 2, 2023 · 1 comment
Open

GitHub Pages #1

charliepnnl opened this issue May 2, 2023 · 1 comment
Assignees

Comments

@charliepnnl
Copy link
Contributor

charliepnnl commented May 2, 2023

We need to serve our single page web app using GitHub Pages. The biggest issue seems to be that GitHub Pages does not directly support a SPA. See https://medium.com/@itspaulolimahimself/deploying-a-react-js-spa-app-to-github-pages-58ddaa2897a3 and https://github.com/rafgraph/spa-github-pages.

Ideally, merging into the main branch will trigger the build and deployment to GitHub Pages.

For May 8:

  • It would be acceptable to perform the build locally and just deploy /build to GitHub Pages.
  • We may not need to worry about the SPA issue if we assume the user will only navigate to /. In this case, GitHub Pages should correctly serve index.html; from there, all navigation will take place within the web app using React Router. This also assumes we've completed Issue Redirect the root route to /app/qa_hpwh/job_1 #2 . Or maybe that won't work well; for example, if the user refreshes the browser after loading the web app.

Beware: The changes needed to allow our SPA to be served from GitHub Pages may not play nicely with our local development environment.

@mvgeorgescu
Copy link
Collaborator

Draft PR: #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants