Avoid overflow in foreign power level outputs #1538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the text reads 'Above Average (137)', it does not fit within 8rem and therefore wraps to two lines. There is enough space for this text to be wider within the layout. (Tested at various widths and layout break-points.) 8rem is too narrow. 9rem is too narrow. 10rem is just wide enough, but does not have much room to grow. 12rem was chosen as a value which fits well in the layouts available (at different break-points), and might work for other languages too. I have not tested with languages other than English.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the text reads 'Above Average (137)', it does not fit within 8rem and therefore wraps to two lines. There is enough space for this text to be wider within the layout. (Tested at various widths and layout break-points.)
8rem is too narrow. 9rem is too narrow. 10rem is just wide enough, but does not have much room to grow. 12rem was chosen as a value which fits well in the layouts available (at different break-points), and might work for other languages too. I have not tested with languages other than English.
Before:
After:
