Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all devtools features #716

Closed
1 task
devanshj opened this issue Dec 17, 2021 · 6 comments
Closed
1 task

Support all devtools features #716

devanshj opened this issue Dec 17, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@devanshj
Copy link
Contributor

devanshj commented Dec 17, 2021

Redux devtools has many more features that we have not implemented yet. For example this tracing feature. The full list of features is here. This will require looking into the (actual) redux's middleware/enhancer's source to see what needs to be done to have these features (and if we can even have them in zustand or not).

Putting it out there in case someone's interested, I might look into it when I have time.


@devanshj devanshj changed the title Support all devtools all features Support all devtools features Dec 17, 2021
@dai-shi
Copy link
Member

dai-shi commented Dec 17, 2021

It feels like we should focus on v4 and work on this after that, unless this introduces any breaking changes. That said, in the meantime, I'm more interested in this for valtio's devtools and jotai's useAtomDevtools.

@DanielPower
Copy link
Contributor

The trace property seems to be mostly working already, just that Zustand isn't typed to accept it. I've put up a PR to allow the trace option to be passed.

I have noticed one problem with this, where a callback passed in for trace will not receive the action as an argument. I'll look into that and address it in a future PR. But for now, just allowing the option to be passed gets us much of the value.

@dai-shi dai-shi added the enhancement New feature or request label Apr 26, 2022
@Aslemammad
Copy link
Member

We tried supporting the trace feature in pmndrs/valtio#331 (PR: pmndrs/valtio#380) but as mentioned, there's an issue in redux devtools trace API (reduxjs/redux-devtools#1100), so I guess we can ignore the trace feature for now if possible, and work again on it in case the trace API works again.

@dai-shi
Copy link
Member

dai-shi commented Jul 26, 2022

#926 is related, right?

@Hideman85
Copy link

The trace feature is really great for debugging, I would to see it available 🙂

@dai-shi
Copy link
Member

dai-shi commented Aug 12, 2023

Closing this as not actionable.
#1200 covers all configs (and #1991 is a better fix).
The trace feature would be nice, but it's blocking. Let's create a new issue once reduxjs/redux-devtools#1369 is published.

If there are other features to support, please open a new discussion.

@dai-shi dai-shi closed this as completed Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants