Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLTFExporter never includes the buffer in JSON #312

Closed
vorth opened this issue Oct 24, 2023 · 1 comment · Fixed by #313
Closed

GLTFExporter never includes the buffer in JSON #312

vorth opened this issue Oct 24, 2023 · 1 comment · Fixed by #313
Labels
bug Something isn't working released

Comments

@vorth
Copy link
Contributor

vorth commented Oct 24, 2023

Problem description:

The bug is visible by inspection:

three-stdlib/src/exporters/GLTFExporter.js

Line 733 in e7b3328

json.buffers[0].uri = uri

The onDone(json) call is performed synchronously, without waiting for the async code setting the uri.
@vorth vorth added the bug Something isn't working label Oct 24, 2023
@CodyJasonBennett CodyJasonBennett mentioned this issue Oct 24, 2023
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 2.28.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(GLTFExporter): return populated json pmndrs/three-stdlib
1 participant
@vorth