feat: refactor control classes to use readonly for target property (#370

)
pmndrs · Aug 5, 2024 · 002e780 · 002e780
1 parent d89e3c3
commit 002e780
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/controls/ArcballControls.ts b/src/controls/ArcballControls.ts
@@ -190,7 +190,7 @@ class ArcballControls extends EventDispatcher {
   public minZoom: number
   public maxZoom: number
 
-  private target: Vector3
+  readonly target: Vector3
   private _currentTarget: Vector3
 
   private _tbRadius: number

diff --git a/src/controls/FirstPersonControls.ts b/src/controls/FirstPersonControls.ts
@@ -49,7 +49,7 @@ export class FirstPersonControls extends EventDispatcher {
 
   private lookDirection = new Vector3()
   private spherical = new Spherical()
-  private target = new Vector3()
+  readonly target = new Vector3()
 
   constructor(object: Camera, domElement?: HTMLElement | null) {
     super()