You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello! I was taking a look at the useBVH storybook and noticed that changing the "splitStrategy" drop down option did not actually change the BVH structure. It seems the line below returns a string rather than one of the three-mesh-bvh constants resulting in an invalid option.
In the newest version of three-mesh-bvh (v0.5.3) a warning will be logged and no splits will be made when an invalid split strategy is provided. Typescript declaration files have also been added which may make these things easier to spot.
Problem description:
Hello! I was taking a look at the
useBVH
storybook and noticed that changing the "splitStrategy" drop down option did not actually change the BVH structure. It seems the line below returns a string rather than one of the three-mesh-bvh constants resulting in an invalid option.In the newest version of three-mesh-bvh (v0.5.3) a warning will be logged and no splits will be made when an invalid split strategy is provided. Typescript declaration files have also been added which may make these things easier to spot.
Relevant code:
Suggested solution:
Change the above line to return the appropriate constant rather than a string.
The text was updated successfully, but these errors were encountered: