-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: Object.defineProperty called on non-object ( mediapipe/tasks-vision ) #1687
Comments
We're going to have to vendor that library and repackage it so it's safe for NPM. The linked issues are for Metro which doesn't understand Node ESM. We have documentation for that specifically: https://docs.pmnd.rs/react-three-fiber/getting-started/installation#react-native. |
IDK if this helps at all since Next is notoriously bad at dynamic or linked dependencies, but I have #1688 which should filter out the broken module. |
You rock, I'll see if this helps and create a minimal repro if I can find some time |
What's bothering me is that we have E2E tests for CRA and Next from a snapshot tgz and they don't encounter this issue. If you find any preferences which are interactive, I'll be sure to add it to our coverage. |
🎉 This issue has been resolved in version 9.88.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is on a next.js project with
@react-three/drei 9.88.2
@react-three/fiber 8.14.5
three 0.157.0
next 13.5.2
three-stdlib 2.27.2
This is both a symptom of something wrong with three shaking and a problem with @mediapipe/tasks-vision, also see:
Screenshot of the error:
The text was updated successfully, but these errors were encountered: