-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: disable obj_sync/TEST[2,5-6] for all configurations until #5646 is fixed #5704
Conversation
Codecov Report
@@ Coverage Diff @@
## stable-1.13 #5704 +/- ##
===============================================
- Coverage 74.30% 74.28% -0.02%
===============================================
Files 145 145
Lines 22133 22134 +1
Branches 3705 3706 +1
===============================================
- Hits 16446 16443 -3
- Misses 5687 5691 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @grom72)
src/test/obj_sync/DISABLE_TEST2
line 11 at r1 (raw file):
by adding the prefix DISABLE_ to the script name.
src/test/obj_sync/DISABLE_TEST5
line 11 at r1 (raw file):
# XXX disable the test for 'drd' # until https://github.com/pmem/pmdk/issues/5646 is fixed # by addind a prefix DISABLE_ to script name
.
src/test/obj_sync/DISABLE_TEST6
line 11 at r1 (raw file):
# XXX disable the test for 'helgrind' # until https://github.com/pmem/pmdk/issues/5646 is fixed # by addind a prefix DISABLE_ to script name.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @grom72)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)
src/test/obj_sync/DISABLE_TEST2
line 11 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
by adding the prefix DISABLE_ to the script name.
Done.
src/test/obj_sync/DISABLE_TEST5
line 11 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
.
Done.
src/test/obj_sync/DISABLE_TEST6
line 11 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r2, all commit messages.
Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r2.
Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @grom72)
src/test/obj_sync/DISABLE_TEST2
line 11 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Done.
adding
src/test/obj_sync/DISABLE_TEST5
line 11 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Done.
.
src/test/obj_sync/DISABLE_TEST6
line 11 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Done.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi)
src/test/obj_sync/DISABLE_TEST2
line 11 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
adding
Done.
src/test/obj_sync/DISABLE_TEST5
line 11 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
.
Done.
src/test/obj_sync/DISABLE_TEST6
line 11 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
Disable tests until the issue #5646 is fixed.
Fixes: #5700.
This change is