common: rpm spec improvements #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plebioda
approved these changes
Apr 4, 2018
krzycz
force-pushed
the
common-rpm_spec_fixes
branch
from
60d78aa to
f8f4048
Compare
Replaces "--with rpmem" with "--with fabric". Makes "check" step to be enabled by default, unless explicilty disabled with "_skip_check=1". Uses default test configuration, if "_testconfig" is not supplied. Adds version to the obsoleted "nvml-tools" subpackage.
krzycz
force-pushed
the
common-rpm_spec_fixes
branch
from
f8f4048 to
5dd6572
Compare
Codecov Report
@@ Coverage Diff @@
## master #2815 +/- ##
=========================================
+ Coverage 77.18% 77.2% +0.01%
=========================================
Files 175 175
Lines 25176 25182 +6
=========================================
+ Hits 19432 19441 +9
+ Misses 5744 5741 -3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces "--with rpmem" with "--with fabric".
Makes "check" step to be enabled by default, unless explicilty disabled
with "_skip_check=1".
Uses default test configuration, if "_testconfig" is not supplied.
Adds version to the obsoleted "nvml-tools" subpackage.
This change is