Make argument count mismatches easier to debug.

rubenlg · pmed · commit fa7f72afba06 · 2023-03-08T20:36:21.000+01:00
Add context on what was the expected number of arguments as well as the actual count.
diff --git a/v8pp/call_from_v8.hpp b/v8pp/call_from_v8.hpp
@@ -93,7 +93,10 @@ decltype(auto) call_from_v8(F&& func, v8::FunctionCallbackInfo<v8::Value> const&
 
 		if (args.Length() != call_traits::arg_count)
 		{
-			throw std::runtime_error("argument count does not match function definition");
+			throw std::runtime_error(
+				"Argument count does not match function definition. Expected " +
+				std::to_string(call_traits::arg_count) + " but got " +
+				std::to_string(args.Length()));
 		}
 
 		if constexpr (with_isolate)

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,10 @@ decltype(auto) call_from_v8(F&& func, v8::FunctionCallbackInfo<v8::Value> const&`
`93`	`93`
`94`	`94`	`if (args.Length() != call_traits::arg_count)`
`95`	`95`	`{`
`96`		`- throw std::runtime_error("argument count does not match function definition");`
	`96`	`+ throw std::runtime_error(`
	`97`	`+ "Argument count does not match function definition. Expected " +`
	`98`	`+ std::to_string(call_traits::arg_count) + " but got " +`
	`99`	`+ std::to_string(args.Length()));`
`97`	`100`	`}`
`98`	`101`
`99`	`102`	`if constexpr (with_isolate)`