Skip to content

Commit

Permalink
Upgrade to node20 (#221)
Browse files Browse the repository at this point in the history
- also removes convert-action

node20 is available since https://github.com/actions/runner/releases/tag/v2.308.0
  • Loading branch information
adangel authored Sep 9, 2023
1 parent 297fa68 commit f22c147
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 63 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/generate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3.8.1
with:
node-version: 16
node-version: 20

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:

- name: Setup Node
uses: actions/setup-node@v3.8.1
with:
node-version: 20

# Compile dist/index.js and bundle with action.yml
# Force push major and minor tags, e.g. v1, v1.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3.8.1
with:
node-version: 16
node-version: 20
- run: npm ci
- run: npm test
4 changes: 2 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ inputs:
[Learn more about creating and using encrypted
secrets](https://docs.github.com/en/actions/security-guides/encrypted-secrets)
required: false
default: '${{ github.token }}'
default: ${{ github.token }}
version:
description: >-
PMD version to use. Using "latest" automatically downloads the latest
Expand Down Expand Up @@ -86,7 +86,7 @@ outputs:
violations:
description: Number of violations found
runs:
using: node16
using: node20
main: dist/index.js
branding:
icon: code
Expand Down
57 changes: 0 additions & 57 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"main": "dist/index.js",
"scripts": {
"lint": "eslint .",
"prepare": "npx ncc build lib/index.js --out dist --minify --license licenses.txt && npx convert-action",
"prepare": "npx ncc build lib/index.js --out dist --minify --license licenses.txt",
"test": "jest --coverage",
"all": "npm run lint && npm run prepare && npm run test"
},
Expand Down Expand Up @@ -35,7 +35,6 @@
"devDependencies": {
"@actions/io": "^1.1.3",
"@vercel/ncc": "^0.38.0",
"convert-action": "^0.3.0",
"eslint": "^8.49.0",
"jest": "^29.6.4",
"nock": "^13.3.3",
Expand Down

0 comments on commit f22c147

Please sign in to comment.