-
Notifications
You must be signed in to change notification settings - Fork 9
Migrate actions to plugwise common gh-actions #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change removes the custom composite GitHub Action for restoring and preparing Python virtual environments, and updates the workflow to use external reusable actions for Python setup and caching. The workflow is streamlined by delegating environment preparation and cache restoration to actions from the Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant plugwise/gh-actions
GitHub Actions->>plugwise/gh-actions: prepare-python-and-code@v1
plugwise/gh-actions-->>GitHub Actions: Python environment prepared
GitHub Actions->>plugwise/gh-actions: restore-venv@v1
plugwise/gh-actions-->>GitHub Actions: venv restored or created
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3410 3410
=========================================
Hits 3410 3410 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/verify.yml (1)
47-53
: Confirm composite action covers checkout & venv setup
Theprepare-python-and-code@v1
step replaces your checkout and venv bootstrap. Verify it actually checks out the repo, installs Python, creates${{ env.VENV }}
, and configures pre-commit.Consider pinning to a full commit SHA for reproducibility.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/actions/restore-venv/action.yml
(0 hunks).github/workflows/verify.yml
(9 hunks)
💤 Files with no reviewable changes (1)
- .github/actions/restore-venv/action.yml
🔇 Additional comments (3)
.github/workflows/verify.yml (3)
68-73
: Ensure ruff restore step has all inputs
Theruff
job’s restore step only listspython-version
; confirmcache-key
,venv-dir
, andprecommit-home
aren’t omitted (or rely on safe defaults).
104-112
: The remainingrestore-venv@v1
invocations across other jobs mirror the pattern reviewed above.Also applies to: 139-147, 171-178, 217-224, 248-255, 282-289
34-36
: ```shell
#!/bin/bash
set -e
echo "Searching for hashFiles usage in .github/workflows/verify.yml"
rg -n "hashFiles" -A2 -B2 .github/workflows/verify.yml || true</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary by CodeRabbit