Skip to content

Conversation

@CoMPaTech
Copy link
Member

Fixes #108

@CoMPaTech CoMPaTech added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Feb 1, 2024
@CoMPaTech CoMPaTech requested a review from a team as a code owner February 1, 2024 11:49
Copy link
Contributor

@dirixmjm dirixmjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bouwew
Copy link
Contributor

bouwew commented Feb 1, 2024

No need to bump the version nr?

@codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19223cd) 35.17% compared to head (27f6a59) 35.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   35.17%   35.17%           
=======================================
  Files          21       21           
  Lines        2405     2405           
=======================================
  Hits          846      846           
  Misses       1559     1559           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CoMPaTech
Copy link
Member Author

No need to bump the version nr?

I think it would be beneficial if someone can actually test this from beta once 2024.2 releases :) Even though no underlying code fixed. And as the work on 0.40 is already commencing I doubt releasing this alfa would matter. But feel free to revert the bump and merge accordingly

@bouwew
Copy link
Contributor

bouwew commented Feb 1, 2024

No objection if you think testing in 2024.2.0 is beneficial :)

@bouwew bouwew merged commit 465c740 into main Feb 1, 2024
@bouwew bouwew deleted the py312 branch February 1, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Python 3.12. compatibility

5 participants