Skip to content

Commit ac620e8

Browse files
authored
Merge pull request #170 from plugwise/catch-up
Catch up
2 parents 4de8063 + ef08962 commit ac620e8

File tree

18 files changed

+158
-132
lines changed

18 files changed

+158
-132
lines changed

.github/workflows/merge.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
name: Latest release
55

66
env:
7-
CACHE_VERSION: 5
7+
CACHE_VERSION: 21
88
DEFAULT_PYTHON: "3.12"
99

1010
# Only run on merges
@@ -22,7 +22,7 @@ jobs:
2222
if: github.event.pull_request.merged == true
2323
steps:
2424
- name: Check out committed code
25-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
25+
uses: actions/checkout@v4
2626
- name: Set up Python ${{ env.DEFAULT_PYTHON }}
2727
id: python
2828
uses: actions/setup-python@v5

.github/workflows/verify.yml

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
name: Latest commit
55

66
env:
7-
CACHE_VERSION: 6
7+
CACHE_VERSION: 22
88
DEFAULT_PYTHON: "3.12"
99
PRE_COMMIT_HOME: ~/.cache/pre-commit
1010

@@ -22,7 +22,7 @@ jobs:
2222
name: Prepare
2323
steps:
2424
- name: Check out committed code
25-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
25+
uses: actions/checkout@v4
2626
- name: Set up Python ${{ env.DEFAULT_PYTHON }}
2727
id: python
2828
uses: actions/setup-python@v5
@@ -48,8 +48,9 @@ jobs:
4848
pip install virtualenv --upgrade
4949
python -m venv venv
5050
. venv/bin/activate
51-
pip install -U pip setuptools wheel
52-
pip install -r requirements_test.txt -r requirements_commit.txt
51+
pip install uv
52+
uv pip install -U pip setuptools wheel
53+
uv pip install -r requirements_test.txt -r requirements_commit.txt
5354
- name: Restore pre-commit environment from cache
5455
id: cache-precommit
5556
uses: actions/cache@v4
@@ -71,7 +72,7 @@ jobs:
7172
needs: prepare
7273
steps:
7374
- name: Check out committed code
74-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
75+
uses: actions/checkout@v4
7576
with:
7677
persist-credentials: false
7778
- name: Set up Python ${{ env.DEFAULT_PYTHON }}
@@ -97,7 +98,7 @@ jobs:
9798
- name: Ruff (check)
9899
run: |
99100
. venv/bin/activate
100-
#ruff plugwise_usb/*py tests/*py
101+
#ruff check plugwise_usb/*py tests/*py
101102
echo "***"
102103
echo "***"
103104
echo "Code is not up to par for ruff, skipping"
@@ -107,7 +108,7 @@ jobs:
107108
if: failure()
108109
run: |
109110
. venv/bin/activate
110-
ruff --fix plugwise_usb/*py tests/*py
111+
ruff check --fix plugwise_usb/*py tests/*py
111112
git config --global user.name 'autoruff'
112113
git config --global user.email 'plugwise_usb@users.noreply.github.com'
113114
git remote set-url origin https://x-access-token:${{ secrets.PAT_CT }}@github.com/$GITHUB_REPOSITORY
@@ -124,7 +125,7 @@ jobs:
124125
- dependencies_check
125126
steps:
126127
- name: Check out committed code
127-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
128+
uses: actions/checkout@v4
128129
- name: Set up Python ${{ env.DEFAULT_PYTHON }}
129130
id: python
130131
uses: actions/setup-python@v5
@@ -175,7 +176,7 @@ jobs:
175176
python-version: ["3.12", "3.11", "3.10"]
176177
steps:
177178
- name: Check out committed code
178-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
179+
uses: actions/checkout@v4
179180
- name: Set up Python ${{ matrix.python-version }}
180181
id: python
181182
uses: actions/setup-python@v5
@@ -199,11 +200,12 @@ jobs:
199200
run: |
200201
python -m venv venv
201202
. venv/bin/activate
202-
pip install -U pip setuptools wheel
203-
#pip install -r requirements_test.txt
203+
pip install uv
204+
uv pip install -U pip setuptools wheel
205+
# uv pip install -r requirements_test.txt
204206
# 20220124 Mimic setup_test.sh
205-
pip install --upgrade -r requirements_test.txt -c https://raw.githubusercontent.com/home-assistant/core/dev/homeassistant/package_constraints.txt -r https://raw.githubusercontent.com/home-assistant/core/dev/requirements_test.txt -r https://raw.githubusercontent.com/home-assistant/core/dev/requirements_test_pre_commit.txt
206-
pip install --upgrade pytest-asyncio
207+
uv pip install --upgrade -r requirements_test.txt -c https://raw.githubusercontent.com/home-assistant/core/dev/homeassistant/package_constraints.txt -r https://raw.githubusercontent.com/home-assistant/core/dev/requirements_test.txt -r https://raw.githubusercontent.com/home-assistant/core/dev/requirements_test_pre_commit.txt
208+
uv pip install --upgrade pytest-asyncio
207209
208210
pytest:
209211
runs-on: ubuntu-latest
@@ -215,7 +217,7 @@ jobs:
215217

216218
steps:
217219
- name: Check out committed code
218-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
220+
uses: actions/checkout@v4
219221
- name: Set up Python ${{ matrix.python-version }}
220222
id: python
221223
uses: actions/setup-python@v5
@@ -251,7 +253,7 @@ jobs:
251253
needs: pytest
252254
steps:
253255
- name: Check out committed code
254-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
256+
uses: actions/checkout@v4
255257
with:
256258
persist-credentials: false
257259
- name: Set up Python ${{ env.DEFAULT_PYTHON }}
@@ -291,7 +293,7 @@ jobs:
291293
runs-on: ubuntu-latest
292294
steps:
293295
- name: Check out committed code
294-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
296+
uses: actions/checkout@v4
295297
- name: Run ShellCheck
296298
uses: ludeeus/action-shellcheck@master
297299

@@ -301,7 +303,7 @@ jobs:
301303
name: Dependency
302304
steps:
303305
- name: Check out committed code
304-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
306+
uses: actions/checkout@v4
305307
- name: Run dependency checker
306308
run: scripts/dependencies_check.sh debug
307309

@@ -311,7 +313,7 @@ jobs:
311313
needs: pytest
312314
steps:
313315
- name: Check out committed code
314-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
316+
uses: actions/checkout@v4
315317
- name: Set up Python ${{ env.DEFAULT_PYTHON }}
316318
id: python
317319
uses: actions/setup-python@v5
@@ -356,7 +358,7 @@ jobs:
356358
needs: [coverage, mypy]
357359
steps:
358360
- name: Check out committed code
359-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
361+
uses: actions/checkout@v4
360362
- name: Set up Python ${{ env.DEFAULT_PYTHON }}
361363
id: python
362364
uses: actions/setup-python@v5
@@ -399,7 +401,7 @@ jobs:
399401
needs: coverage
400402
steps:
401403
- name: Check out committed code
402-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
404+
uses: actions/checkout@v4
403405
- name: Set up Python ${{ env.DEFAULT_PYTHON }}
404406
id: python
405407
uses: actions/setup-python@v5

.pre-commit-config.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ repos:
2828
args:
2929
- --branch=main
3030
- repo: https://github.com/asottile/pyupgrade
31-
rev: v3.16.0
31+
rev: v3.17.0
3232
hooks:
3333
- id: pyupgrade
3434
args: [--py39-plus]
@@ -51,10 +51,12 @@ repos:
5151
rev: v1.35.1
5252
hooks:
5353
- id: yamllint
54-
- repo: https://github.com/pre-commit/mirrors-prettier
55-
rev: v3.1.0
54+
- repo: https://github.com/biomejs/pre-commit
55+
rev: v0.4.0
5656
hooks:
57-
- id: prettier
57+
- id: biome-lint
58+
additional_dependencies: ["@biomejs/biome@1.8.3"]
59+
name: "Verifying/updating code with biome (improved prettier)"
5860
- repo: https://github.com/cdce8p/python-typing-update
5961
rev: v0.6.0
6062
hooks:

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## Ongoing
4+
5+
- Ensure CI process remains operational
6+
- Bumped pip to now prepend uv for using quicker dependency resolving and installing
7+
- As for latest HA Core USB team should rework to python 3.12 (not still 3.10)
8+
39
## v0.31.4(a0)
410

511
- Re-add python 3.12 checks and compatibility

plugwise_usb/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -538,8 +538,7 @@ def _pass_message_to_node(self, message, mac, discover=True):
538538
return False
539539

540540
def _watchdog_loop(self):
541-
"""Main worker loop to watch all other worker threads
542-
"""
541+
"""Main worker loop to watch all other worker threads"""
543542
time.sleep(5)
544543
circle_plus_retry_counter = 0
545544
while self._run_watchdog:

plugwise_usb/controller.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ def _post_message_action(self, seq_id, ack_response=None, request="unknown"):
327327
request,
328328
str(seq_id),
329329
)
330-
#Still save it to try and get it back into sync
330+
# Still save it to try and get it back into sync
331331
self.last_seq_id = seq_id
332332
if resend_request:
333333
self.resend(seq_id)

plugwise_usb/messages/responses.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@
2323

2424

2525
class NodeResponse(PlugwiseMessage):
26-
"""Base class for response messages received by USB-Stick.
27-
"""
26+
"""Base class for response messages received by USB-Stick."""
2827

2928
def __init__(self, format_size=None):
3029
super().__init__()
@@ -561,8 +560,7 @@ def __init__(self):
561560

562561

563562
def get_message_response(message_id, length, seq_id):
564-
"""Return message class based on sequence ID, Length of message or message ID.
565-
"""
563+
"""Return message class based on sequence ID, Length of message or message ID."""
566564
# First check for known sequence ID's
567565
if seq_id == b"FFFD":
568566
return NodeJoinAckResponse()

0 commit comments

Comments
 (0)