Implement improvement suggestions from SonarCloud

Author: bouwew

custom_components/plugwise/coordinator.py

@@ -154,17 +154,17 @@ async def _async_remove_devices(self, data: dict[str, GwEntityData]) -> None:
         # Then remove the connected orphaned device(s)
         for device_entry in device_list:
             for identifier in device_entry.identifiers:
-                if identifier[0] == DOMAIN:
-                    if (
-                        device_entry.via_device_id == via_device_id
-                        and identifier[1] not in data
-                    ):
-                        device_reg.async_update_device(
-                            device_entry.id, remove_config_entry_id=self.config_entry.entry_id
-                        )
-                        LOGGER.debug(
-                            "Removed %s device/zone %s %s from device_registry",
-                            DOMAIN,
-                            device_entry.model,
-                            identifier[1],
-                        )
+                if (
+                    identifier[0] == DOMAIN
+                    and device_entry.via_device_id == via_device_id
+                    and identifier[1] not in data
+                ):
+                    device_reg.async_update_device(
+                        device_entry.id, remove_config_entry_id=self.config_entry.entry_id
+                    )
+                    LOGGER.debug(
+                        "Removed %s device/zone %s %s from device_registry",
+                        DOMAIN,
+                        device_entry.model,
+                        identifier[1],
+                    )

tests/components/plugwise/test_init.py

@@ -328,7 +328,7 @@ async def test_update_device(
             == 9
         )
         item_list: list[str] = []
-        for device_entry in list(device_registry.devices.values()):
+        for device_entry in device_registry.devices.values():
             item_list.extend(x[1] for x in device_entry.identifiers)
         assert "01234567890abcdefghijklmnopqrstu" in item_list
 
@@ -355,6 +355,6 @@ async def test_update_device(
             == 8
         )
         item_list: list[str] = []
-        for device_entry in list(device_registry.devices.values()):
+        for device_entry in device_registry.devices.values():
             item_list.extend(x[1] for x in device_entry.identifiers)
         assert "1772a4ea304041adb83f357b751341ff" not in item_list