fix(formanswer): too many escaping

btry · btry · commit e518b7de1a69 · 2023-05-05T09:28:55.000+02:00
when a formanswer name contains a single quote, it is escaped twice fix #3271
diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
@@ -837,7 +837,7 @@ public function prepareInputForAdd($input) {
       }
 
       try {
-         $input['name'] = $DB->escape($this->parseTags($form->fields['formanswer_name']));
+         $input['name'] = $this->parseTags($form->fields['formanswer_name']);
       } catch (Exception $e) {
          // A fatal error caught during parsing of tags
          $GLPI->getErrorHandler()->handleException($e, false);

Original file line number	Diff line number	Diff line change
`@@ -837,7 +837,7 @@ public function prepareInputForAdd($input) {`
`837`	`837`	`}`
`838`	`838`
`839`	`839`	`try {`
`840`		`- $input['name'] = $DB->escape($this->parseTags($form->fields['formanswer_name']));`
	`840`	`+ $input['name'] = $this->parseTags($form->fields['formanswer_name']);`
`841`	`841`	`} catch (Exception $e) {`
`842`	`842`	`// A fatal error caught during parsing of tags`
`843`	`843`	`$GLPI->getErrorHandler()->handleException($e, false);`