fix(issue): prevent fatal error in tooltip

btry · btry · commit 3419affcf0e3 · 2023-05-31T15:53:35.000+02:00
when a tooltip for an issue of a form answer is generated, an inconcistency in conditions may cause a crash
diff --git a/inc/issue.class.php b/inc/issue.class.php
@@ -1063,7 +1063,11 @@ public static function giveItem($itemtype, $option_id, $data, $num) {
                      trigger_error(sprintf("Formanswer ID %s not found", $id), E_USER_WARNING);
                      break;
                   }
-                  $content = $formAnswer->parseTags($formAnswer->getFullForm());
+                  try {
+                     $content = $formAnswer->parseTags($formAnswer->getFullForm());
+                  } catch (Exception $e) {
+                     $content = ''; // Exception when computing the tooltip
+                  }
                   break;
             }
             $link = self::getFormURLWithID($data['id']);

Original file line number	Diff line number	Diff line change
`@@ -1063,7 +1063,11 @@ public static function giveItem($itemtype, $option_id, $data, $num) {`
`1063`	`1063`	`trigger_error(sprintf("Formanswer ID %s not found", $id), E_USER_WARNING);`
`1064`	`1064`	`break;`
`1065`	`1065`	`}`
`1066`		`- $content = $formAnswer->parseTags($formAnswer->getFullForm());`
	`1066`	`+ try {`
	`1067`	`+ $content = $formAnswer->parseTags($formAnswer->getFullForm());`
	`1068`	`+ } catch (Exception $e) {`
	`1069`	`+ $content = ''; // Exception when computing the tooltip`
	`1070`	`+ }`
`1067`	`1071`	`break;`
`1068`	`1072`	`}`
`1069`	`1073`	`$link = self::getFormURLWithID($data['id']);`