fix: SQL error when inconsistency in DB

btry · btry · commit 1af78720dfa8 · 2023-04-19T08:09:14.000+02:00
if a user is linked to a not existing group, a SQL IN statement begins with a comma fix #3242
diff --git a/hook.php b/hook.php
@@ -265,6 +265,9 @@ function plugin_formcreator_addDefaultWhere($itemtype) {
 
             $groupIDs = [];
             foreach ($groups as $group) {
+               if ($group['id'] === null) {
+                  continue;
+               }
                $groupIDs[] = $group['id'];
             }
             $groupIDs = implode(',', $groupIDs);

Original file line number	Diff line number	Diff line change
`@@ -265,6 +265,9 @@ function plugin_formcreator_addDefaultWhere($itemtype) {`
`265`	`265`
`266`	`266`	`$groupIDs = [];`
`267`	`267`	`foreach ($groups as $group) {`
	`268`	`+ if ($group['id'] === null) {`
	`269`	`+ continue;`
	`270`	`+ }`
`268`	`271`	`$groupIDs[] = $group['id'];`
`269`	`272`	`}`
`270`	`273`	`$groupIDs = implode(',', $groupIDs);`