feat(forms): add Fields question type and category implementation (#1060)

* feat(forms): add Fields question type and category implementation

* fix: Rector lint

* fix: Twig lint

* fix: PHPStan + remove code duplication

Author: ccailly

.gitignore

@@ -1,4 +1,7 @@
-dist/
-vendor/
+/dist/
+/node_modules/
+/vendor/
 .gh_token
+.phpunit.result.cache
+tests/files/
 *.min.*

CHANGELOG.md

@@ -5,9 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
-
 ## [UNRELEASED]
 
+### Added
+
+- Implement `Field` question type for new GLPI forms
+
 ## [1.22.2] - 2025-10-24
 
 ### Fixed

Makefile

@@ -0,0 +1 @@
+include ../../PluginsMakefile.mk

inc/field.class.php

@@ -30,6 +30,7 @@
 use Glpi\Features\Clonable;
 use Glpi\DBAL\QueryExpression;
 use Glpi\Application\View\TemplateRenderer;
+use Glpi\Form\Question;
 
 class PluginFieldsField extends CommonDBChild
 {
@@ -350,6 +351,27 @@ public function pre_deleteItem()
          */
         global $DB;
 
+        // Check if the field is used in a form question
+        $question = new Question();
+        $found = $question->find([
+            'type' => PluginFieldsQuestionType::class,
+            $this->fields['id'] => new QueryExpression(sprintf(
+                "JSON_VALUE(%s, '$.field_id')",
+                DBmysql::quoteName('extra_data'),
+            )),
+        ]);
+        if (!empty($found)) {
+            $question->getFromDB(current($found)['id']);
+            Session::addMessageAfterRedirect(
+                msg: $question->formatSessionMessageAfterAction(sprintf(
+                    __('The field "%s" cannot be deleted because it is used in a form question', 'fields'),
+                    $this->fields['label'],
+                )),
+                message_type: ERROR,
+            );
+            return false;
+        }
+
         //retrieve search option ID to clean DiplayPreferences
         $container_obj = new PluginFieldsContainer();
         $container_obj->getFromDB($this->fields['plugin_fields_containers_id']);