refactor: ActionManagerComponent.tsx and fix rare render race condition #203
+61
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boazpoolman
approved these changes
Jun 29, 2025
Member
boazpoolman
left a comment
boazpoolman
left a comment
There was a problem hiding this comment.
I'm unable to reproduce the flickering bug from #202.
Though I can confirm that this PR doesn't cause any issues, so I approve!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #202
What does it do?
-Fix flickering publisher panel
-Clean-up code for better readability
Why is it needed?
-Fix flickering publisher panel
How to test?
Set plugin.ts config to:
'publisher': {
enabled: true,
config: {
contentTypes: ['api::article.article'],
},
},
Refresh article and page as example and see if there is no react error popping up or any other weird behaviour