Fix [note] slowness

Author: timothyschoen

Source/Objects/NoteObject.h

@@ -429,14 +429,21 @@ class NoteObject final : public ObjectBase {
         if (typefaceName.isEmpty() || typefaceName == "Inter") {
             return Fonts::getVariableFont().withStyle(style).withHeight(fontHeight);
         }
+        
+        // Check if a system typeface exists, before we start searching for a font file
+        // We do this because it's the most common case, and finding font files is slow
+        if(Font::findAllTypefaceNames().contains(typefaceName))
+        {
+            return { typefaceName, static_cast<float>(fontHeight), style };
+        }
 
         auto currentFile = cnv->patch.getCurrentFile();
         if (currentFile.exists() && !currentFile.isRoot()) {
             // Check if there is a patch font loaded via the patch loading
             if (auto const patchFont = Fonts::findFont(currentFile, typefaceName); patchFont.has_value())
                 return patchFont->withStyle(style).withHeight(fontHeight);
         }
-
+        
         return { typefaceName, static_cast<float>(fontHeight), style };
     }
 

Source/Utility/Fonts.h

@@ -70,8 +70,7 @@ struct Fonts {
 
     static std::optional<Font> findFont(File const& dirToSearch, String const& typefaceFileName)
     {
-        Array<File> fontFiles = dirToSearch.getParentDirectory().findChildFiles(File::findFiles, true, "*.ttf;*.otf;");
-
+        Array<File> fontFiles = dirToSearch.getParentDirectory().findChildFiles(File::findFiles, false, "*.ttf;*.otf;");
         for (auto font : fontFiles) {
             if (font.getFileNameWithoutExtension() == typefaceFileName) {
                 auto it = fontTable.find(font.getFullPathName());