Skip to content

Commit a89b59c

Browse files
committed
Set (back) stemming by default and expose '--no_stemming' flag
1 parent 2b12c18 commit a89b59c

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ optional arguments:
2424
File to save scores
2525
-e EOS, --eos EOS End of sentence separator (for multisentence).
2626
Default: "."
27-
-m, --stemming
27+
-m, --stemming DEPRECATED: stemming is now default behavior
28+
-nm, --no_stemming Switch off stemming
2829
-i, --ignore_empty
2930
```
3031

files2rouge/files2rouge.py

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def run(summ_path,
3030
saveto=None,
3131
eos=".",
3232
ignore_empty=False,
33-
stemming=False):
33+
stemming=True):
3434
s = settings.Settings()
3535
s._load()
3636
stime = time()
@@ -68,7 +68,7 @@ def run(summ_path,
6868
else:
6969
rouge_args_str = rouge_args
7070
rouge_args_str = "%s %s" % (data_arg, rouge_args_str)
71-
71+
7272
output = r.convert_and_evaluate(rouge_args=rouge_args_str)
7373

7474
if saveto is not None:
@@ -91,18 +91,26 @@ def main():
9191
parser.add_argument('-e', '--eos', dest="eos", default='.',
9292
help="""End of sentence separator (for multisentence).
9393
Default: \".\" """)
94-
parser.add_argument("-m", "--stemming", action="store_true")
94+
parser.add_argument("-m", "--stemming", action="store_true",
95+
help="DEPRECATED: stemming is now default behavior")
96+
parser.add_argument("-nm", "--no_stemming", action="store_true",
97+
help="Switch off stemming")
9598
parser.add_argument("-i", "--ignore_empty", action="store_true")
9699
args = parser.parse_args()
97100

101+
if args.stemming:
102+
raise ValueError(
103+
"""files2rouge uses stemming by default so --stemming is
104+
deprecated. You can turn it off with -nm/--no_stemming""")
105+
98106
run(args.summary,
99107
args.reference,
100-
args.args,
101-
args.verbose,
102-
args.saveto,
103-
args.eos,
104-
args.ignore_empty,
105-
args.stemming)
108+
rouge_args=args.args,
109+
verbose=args.verbose,
110+
saveto=args.saveto,
111+
eos=args.eos,
112+
ignore_empty=args.ignore_empty,
113+
stemming=not args.no_stemming)
106114

107115

108116
if __name__ == '__main__':

0 commit comments

Comments
 (0)