Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meta titles #846

Merged
merged 3 commits into from
Feb 17, 2019
Merged

Fix meta titles #846

merged 3 commits into from
Feb 17, 2019

Conversation

VeraZab
Copy link
Contributor

@VeraZab VeraZab commented Feb 17, 2019 •
edited
Loading

@VeraZab
Copy link
Contributor Author

VeraZab commented Feb 17, 2019 •
edited
Loading

note that setting trace titles, timescale buttons, is not yet possible, but will be in next plotly.js release: plotly/plotly.js#3541

bpostlethwaite
bpostlethwaite approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@bpostlethwaite bpostlethwaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 great!

@bpostlethwaite
Copy link
Member

Any other places we need the template string? @dmt0 care to take a look? If not, let's get this in and do another PR later if necessary

@VeraZab VeraZab merged commit fce716e into master Feb 17, 2019
@VeraZab VeraZab deleted the fix-meta-titles branch February 17, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpostlethwaite bpostlethwaite bpostlethwaite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VeraZab @bpostlethwaite