Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choropleth improvements #947

Merged
merged 7 commits into from
Mar 7, 2018
Merged

choropleth improvements #947

merged 7 commits into from
Mar 7, 2018

Conversation

Kully
Copy link
Contributor

@Kully Kully commented Feb 28, 2018

addresses: #944

Also does:

  • enhancement from rename offline_mode param from ff.create_choropleth #944
  • Turns off hover for the lines. It fights with hover for the centroids.
  • Turns on persistent selection api for the centroid points, so that the centroids are invisible until you select, then they show up in white with a thin border.
  • 0-pad the 4 digit FIPS numbers of the legend

@Kully Kully changed the title turn off hover for the lines choropleth improvements Feb 28, 2018
@Kully
Copy link
Contributor Author

Kully commented Feb 28, 2018

ready for a review when tests pass
cc: @cldougl @jackparmer

Perhaps this should also be version 2.5.0 Chelsea?

@jackparmer
Copy link
Contributor

💃 from me

@Kully
Copy link
Contributor Author

Kully commented Mar 1, 2018

@cldougl

@cldougl
Copy link
Member

cldougl commented Mar 5, 2018

@Kully I don't think the package data should be added in the test directory: https://github.com/plotly/plotly.py/tree/master/plotly/tests/test_optional/test_figure_factory

don't you want to be testing that the package data is read properly from: https://github.com/plotly/plotly.py/tree/master/plotly/package_data ?

@cldougl
Copy link
Member

cldougl commented Mar 5, 2018

re: #947 (comment)
👍 yep version 2.5.0

@cldougl
Copy link
Member

cldougl commented Mar 7, 2018

💃

@Kully Kully merged commit 8c7eb17 into master Mar 7, 2018
@Kully Kully deleted the offline_mode_choropleth branch March 7, 2018 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants