Convert base64 in BaseFigure.to_dict instead of validate_coerce #4784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting to base64 in validate_coerce_fig_to_dict offers the same performance improvements without changing the output of the data field of the Figure object.
gvwilson
reviewed
Oct 8, 2024
| for trace in fig_dict["data"]: | ||
| for key, value in trace.items(): | ||
| if is_homogeneous_array(value): | ||
| print("to typed array: key:", key, "value:", value) |
There was a problem hiding this comment.
is this a stray debugging statement?
marthacryan
changed the title
|
Nice discovery! Thanks to @marthacryan and @emilykl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting to base64 in BaseFigure.to_dict() offers the same performance improvements without changing the output of the data field of the Figure object. This will only be called through
show()or in dash