Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New mapbox functions in PX #1937

Merged
merged 8 commits into from
Dec 2, 2019
Merged

New mapbox functions in PX #1937

merged 8 commits into from
Dec 2, 2019

Conversation

nicolaskruchten
Copy link
Contributor

I'll add a couple of tests here and then this should be good to go :)

@nicolaskruchten
Copy link
Contributor Author

And then we'll need to update some docs to show off the new functions!

constructor=go.Choroplethmapbox,
trace_patch=dict(
geojson=geojson
if not hasattr(geojson, "__geo_interface__")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is geopandas-specific code so that you can just say ...geojson=geo_df.geometry... :)

@emmanuelle
Copy link
Contributor

emmanuelle commented Dec 2, 2019

Exactly if the doc migration PR is merged then you can add directly the updates to the doc!

@emmanuelle
Copy link
Contributor

So the percy script fails because it's missing the center argument which has just been introduced here.

@nicolaskruchten
Copy link
Contributor Author

Hah, yes, hurray tests :)

@emmanuelle
Copy link
Contributor

💃, thanks!

@nicolaskruchten nicolaskruchten merged commit 329beb9 into master Dec 2, 2019
@nicolaskruchten nicolaskruchten added this to the v4.4.0 milestone Dec 10, 2019
@nicolaskruchten nicolaskruchten deleted the px_new_functions branch June 19, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants