Skip to content

Restructure repo with a top-level packages/ directory #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 13, 2019
Merged

Restructure repo with a top-level packages/ directory #1604

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
152b1df
Restructure repo with a top-level `packages/` directory
jonmmease Jun 10, 2019
384a27f
Empty files
jonmmease Jun 10, 2019
d06ff6d
Fix circle ci testing paths
jonmmease Jun 10, 2019
da290d4
Remove node_modules fro git
jonmmease Jun 10, 2019
a5ce761
Fix more circleci paths
jonmmease Jun 10, 2019
a702baf
Fix codegen paths
jonmmease Jun 10, 2019
fd245e0
Fix test paths
jonmmease Jun 10, 2019
361560f
Fix circle ci path
jonmmease Jun 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test paths
  • Loading branch information
@jonmmease
jonmmease committed Jun 10, 2019
commit fd245e001ff3529bf55b66636010f89fbcfdb83c
12 changes: 9 additions & 3 deletions packages/python/plotly/plotly/tests/test_core/test_offline/test_offline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@
import plotly.io as pio
import json

project_root = os.path.dirname(
packages_root = os.path.dirname(
os.path.dirname(
os.path.dirname(
os.path.realpath(plotly.__file__))))
os.path.dirname(
os.path.realpath(plotly.__file__)))))

here = os.path.dirname(os.path.realpath(__file__))
html_filename = os.path.join(here, 'temp-plot.html')
Expand Down Expand Up @@ -311,7 +312,12 @@ def get_html():

@attr('nodev')
def test_plotlyjs_version(self):
path = os.path.join(project_root, 'js', 'package.json')
path = os.path.join(
packages_root,
'javascript',
'plotlywidget',
'package.json',
)
with open(path, 'rt') as f:
package_json = json.load(f)
expected_version = package_json['dependencies']['plotly.js']
Expand Down