Skip to content

Introducing Plotly.update #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 7, 2016
Merged

Introducing Plotly.update #875

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
17e7e79
plot api: move common routine to helpers.js
etpinard Aug 22, 2016
b2a072a
plot api: add proper jsDoc to restyle and relayout
etpinard Aug 22, 2016
3024b71
plot api: move plot/update sub-routine to subroutines.js
etpinard Aug 22, 2016
ce51b21
plot api: rm unused 'dolayout' flag in restyle
etpinard Aug 22, 2016
497203d
plot api: refactor Plotly.restyle
etpinard Aug 22, 2016
e1a989f
plot api: rm unused annotation ref -> xref/yref translate step
etpinard Aug 22, 2016
822cf8c
plot api: refactor Plotly.relayout
etpinard Aug 22, 2016
7752eb4
add Plotly.update method:
etpinard Aug 22, 2016
26c4075
test: add test for Plotly.update
etpinard Aug 22, 2016
c3327aa
Merge branch 'master' into update-method
etpinard Sep 6, 2016
01967d8
merge followup: use helpers.getGraphDiv in animate/frame methods
etpinard Sep 6, 2016
e8dbf55
improve jsDoc for restyle/relayout/update
etpinard Sep 6, 2016
3db6d21
dry: pull trace indices input -> list logic in helpers
etpinard Sep 6, 2016
c15a617
test: adapt transition test to more strict 'traces' API
etpinard Sep 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: adapt transition test to more strict 'traces' API
  • Loading branch information
@etpinard
etpinard committed Sep 6, 2016
commit c15a617bf053f14d03855c35bbe2ae19becb51f3
15 changes: 11 additions & 4 deletions test/jasmine/tests/transition_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
var Plotly = require('@lib/index');
var Lib = require('@src/lib');
var Plots = Plotly.Plots;
var plotApiHelpers = require('@src/plot_api/helpers');

var createGraphDiv = require('../assets/create_graph_div');
var destroyGraphDiv = require('../assets/destroy_graph_div');
Expand Down Expand Up @@ -29,8 +30,9 @@ function runTests(transitionDuration) {

it('resolves only once the transition has completed', function(done) {
var t1 = Date.now();
var traces = plotApiHelpers.coerceTraceIndices(gd, null);

Plots.transition(gd, null, {'xaxis.range': [0.2, 0.3]}, null, {redraw: true}, {duration: transitionDuration, easing: 'cubic-in-out'})
Plots.transition(gd, null, {'xaxis.range': [0.2, 0.3]}, traces, {redraw: true}, {duration: transitionDuration, easing: 'cubic-in-out'})
.then(delay(20))
.then(function() {
expect(Date.now() - t1).toBeGreaterThan(transitionDuration);
Expand All @@ -39,9 +41,11 @@ function runTests(transitionDuration) {

it('emits plotly_transitioning on transition start', function(done) {
var beginTransitionCnt = 0;
var traces = plotApiHelpers.coerceTraceIndices(gd, null);

gd.on('plotly_transitioning', function() { beginTransitionCnt++; });

Plots.transition(gd, null, {'xaxis.range': [0.2, 0.3]}, null, {redraw: true}, {duration: transitionDuration, easing: 'cubic-in-out'})
Plots.transition(gd, null, {'xaxis.range': [0.2, 0.3]}, traces, {redraw: true}, {duration: transitionDuration, easing: 'cubic-in-out'})
.then(delay(20))
.then(function() {
expect(beginTransitionCnt).toBe(1);
Expand All @@ -50,9 +54,11 @@ function runTests(transitionDuration) {

it('emits plotly_transitioned on transition end', function(done) {
var trEndCnt = 0;
var traces = plotApiHelpers.coerceTraceIndices(gd, null);

gd.on('plotly_transitioned', function() { trEndCnt++; });

Plots.transition(gd, null, {'xaxis.range': [0.2, 0.3]}, null, {redraw: true}, {duration: transitionDuration, easing: 'cubic-in-out'})
Plots.transition(gd, null, {'xaxis.range': [0.2, 0.3]}, traces, {redraw: true}, {duration: transitionDuration, easing: 'cubic-in-out'})
.then(delay(20))
.then(function() {
expect(trEndCnt).toEqual(1);
Expand All @@ -70,7 +76,8 @@ function runTests(transitionDuration) {
gd.on('plotly_transitioned', function() { currentlyRunning--; endCnt++; });

function doTransition() {
return Plots.transition(gd, [{x: [1, 2]}], null, null, {redraw: true}, {duration: transitionDuration, easing: 'cubic-in-out'});
var traces = plotApiHelpers.coerceTraceIndices(gd, null);
return Plots.transition(gd, [{x: [1, 2]}], null, traces, {redraw: true}, {duration: transitionDuration, easing: 'cubic-in-out'});
}

function checkNoneRunning() {
Expand Down