Skip to content

fix regl_codegen #7125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Aug 21, 2024

This fixes the regl_codegen, by making sure the files first are generated, and then the server and devtools are launched after - not the other way around

@archmoj
Copy link
Contributor

archmoj commented Aug 22, 2024

Wow thanks for taking this one 🙏

@archmoj
Copy link
Contributor

archmoj commented Aug 22, 2024

This still requires additional adjustments.
By calling npm run regl-codegen it should display a devtool and automatically start drawing all the gl2d and parcoords mocks one after another.

@birkskyum
Copy link
Contributor Author

birkskyum commented Aug 22, 2024

This still requires additional adjustments. By calling npm run regl-codegen it should display a devtool and automatically start drawing all the gl2d and parcoords mocks one after another.

That is what i see now, it draws them in the browser

@archmoj
Copy link
Contributor

archmoj commented Aug 22, 2024

Hmm.. then perhaps I am missing some requirements on my machine.
I'll move forward and merge it.
Thank you!

@archmoj archmoj merged commit e0faf1d into plotly:build-with-esbuild Aug 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants