Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for openmaptiles open sans extrabold #7020

Closed
wants to merge 2 commits into from

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Jun 6, 2024

Openmaptiles call the Open Sans Extrabold for Open Sans Extra Bold

Affecting the scattermapbox trace

@birkskyum birkskyum mentioned this pull request Jun 6, 2024
@archmoj
Copy link
Contributor

archmoj commented Jun 6, 2024

Some carto mapbox baseline failures are fixed in #7019 today.
Please fetch upstream/master and then merge master into this pull request as well as into other PRs you have open.
Thank you!

@archmoj
Copy link
Contributor

archmoj commented Jun 6, 2024

The extra bold does not render properly on this branch if you view mapbox_fonts-supported-open-sans-weight mock.

@birkskyum
Copy link
Contributor Author

Hmm, so it's not broken in the first place? Strange, i had that impression.

@birkskyum birkskyum closed this Jun 6, 2024
@birkskyum
Copy link
Contributor Author

birkskyum commented Jun 6, 2024

Ah, it's because this is a problem only after moving to maplibre, where the Extra Bold font appear completely missing, and adding this patch does render text, but it's not bold, so there is a fix needed for that in the MapLibre branch.

@archmoj
Copy link
Contributor

archmoj commented Jun 6, 2024

Ah, it's because this is a problem only after moving to maplibre, where the Extra Bold font appear completely missing, and adding this patch does render text, but it's not bold, so there is a fix needed for that in the MapLibre branch.

OK. Let's keep the patch inside the maplibre PR.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants