Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup weekly and quarterly period label positioning and with rangebreaks #5089

Merged
merged 24 commits into from
Sep 2, 2020
Merged

Fixup weekly and quarterly period label positioning and with rangebreaks #5089

merged 24 commits into from
Sep 2, 2020

Commits on Aug 19, 2020

  1. center weekly labels on weekend rangebreaks

    @archmoj
    archmoj committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    1a09b58 View commit details
    Browse the repository at this point in the history

  2. improve quarters and year period label positioning

    @archmoj
    archmoj committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    9fce7ad View commit details
    Browse the repository at this point in the history

  3. reduce min quarter constant for the edge case of Feb-Mar-Apr

    @archmoj
    archmoj committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    8928851 View commit details
    Browse the repository at this point in the history

  4. add logic for special case of weeks and quarters

    @archmoj
    archmoj committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    ea6eca1 View commit details
    Browse the repository at this point in the history

  5. use tickfromat getter and add question comment

    @archmoj
    archmoj committed Aug 19, 2020
    2 Configuration menu
    Copy the full SHA
    37a0840 View commit details
    Browse the repository at this point in the history

  6. more fixups for period tickformat

    @archmoj
    archmoj committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    e0bd026 View commit details
    Browse the repository at this point in the history

  7. remove comment

    @archmoj
    archmoj committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    6fb0133 View commit details
    Browse the repository at this point in the history

  8. revise period lengths on axes with rangebreaks

    @archmoj
    archmoj committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    f907f2a View commit details
    Browse the repository at this point in the history

  9. do not recalculate periodLength when zero

    @archmoj
    archmoj committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    fa5d2e3 View commit details
    Browse the repository at this point in the history

  10. reduce sampling

    @archmoj
    archmoj committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    b318e8b View commit details
    Browse the repository at this point in the history

  11. should not move by a week or quarter when the labels are not weekly o… 

    …r quarterly
    @archmoj
    archmoj committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    beed352 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. use formatter in the variable name of the entire tickformat

    @archmoj
    archmoj committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    104ae5e View commit details
    Browse the repository at this point in the history

  2. add tests for auto labels and rangebreaks

    @archmoj
    archmoj committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    7febd59 View commit details
    Browse the repository at this point in the history

  3. add hovertemplate to make debugging easier in future

    @archmoj
    archmoj committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    636531b View commit details
    Browse the repository at this point in the history

  4. make week and quarter labels mode readable in tests

    @archmoj
    archmoj committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    dddcaa8 View commit details
    Browse the repository at this point in the history

  5. add tests for period labels on axes with reversed ranges

    @archmoj
    archmoj committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    b32b5a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. position quarters in period mode - case of dtick set to M6

    @archmoj
    archmoj committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    350a10a View commit details
    Browse the repository at this point in the history

  2. skip labels with identical text as previous label

    @archmoj
    archmoj committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    50a3451 View commit details
    Browse the repository at this point in the history

  3. ensure new label positions remains between ticks

    @archmoj
    archmoj committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    2920e31 View commit details
    Browse the repository at this point in the history

  4. adjust AM/PM period case

    @archmoj
    archmoj committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    12ce066 View commit details
    Browse the repository at this point in the history

  5. adjust hour period case

    @archmoj
    archmoj committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    f47c820 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. adjust period labels depending on break size

    @archmoj
    archmoj committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    c080bc5 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. adjust period labels for the case of big gaps

    @archmoj
    archmoj committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    4c10ddd View commit details
    Browse the repository at this point in the history

  2. split sampling over first and second halves

    @archmoj
    archmoj committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    5775048 View commit details
    Browse the repository at this point in the history