reduce plot api imports

[archmoj]

Refactoring plot_api files (i.e. excluding plot_api.js) to reduce imported functions and help increase code readability.

@etpinard

[etpinard]

To be honest @archmoj, I don't see how this makes our code more readable.

I agree our import/export statements could be standardised better, but I think we can wait when we'll make a push for ES6 to spend time on this.

[etpinard]

@archmoj ok to close this thing?

[archmoj]

To be honest @archmoj, I don't see how this makes our code more readable.

I agree our import/export statements could be standardised better, but I think we can wait when we'll make a push for ES6 to spend time on this.

Your call.
Anyway here is one example if one searches for isPlainObject in https://github.com/plotly/plotly.js/blob/b6503ac2682bab35e7e6949696a7ce029cba00da/src/plot_api/plot_schema.js there are two ways which is called i.e. with/without Lib..

[etpinard]

Ok, I agree the patch you made to plot_schema.js is 👌

[archmoj]

The only function used from Plots in this file is subplotsRegistry.

[etpinard]

Is there a way to enforce this rule using eslint? If not, than we don't need to do this.

[etpinard]

Thanks @archmoj 💃