Skip to content

Commit ea4d8a2

Browse files
committed
no need to sort & revert ticktext logic
1 parent 19a0c75 commit ea4d8a2

File tree

3 files changed

+2
-20
lines changed

3 files changed

+2
-20
lines changed

src/plots/cartesian/axes.js

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -586,9 +586,7 @@ axes.calcTicks = function calcTicks(ax) {
586586
var tickVals;
587587
function generateTicks() {
588588
var xPrevious = null;
589-
590589
var maxTicks = Math.max(1000, ax._length || 0);
591-
592590
tickVals = [];
593591
for(var x = ax._tmin;
594592
(axrev) ? (x >= endTick) : (x <= endTick);
@@ -635,11 +633,6 @@ axes.calcTicks = function calcTicks(ax) {
635633
}
636634
}
637635

638-
// sort
639-
tickVals = tickVals.sort(function(a, b) {
640-
return a.value - b.value;
641-
});
642-
643636
// reduce ticks
644637
var len = tickVals.length;
645638
if(len > 2) {
@@ -676,25 +669,14 @@ axes.calcTicks = function calcTicks(ax) {
676669
ax._prevDateHead = '';
677670
ax._inCalcTicks = true;
678671

679-
var prevLabel;
680-
var ticksOut = [];
672+
var ticksOut = new Array(tickVals.length);
681673
for(var i = 0; i < tickVals.length; i++) {
682-
var label = axes.tickText(
674+
ticksOut[i] = axes.tickText(
683675
ax,
684676
tickVals[i].value,
685677
false, // hover
686678
tickVals[i].minor // noSuffixPrefix
687679
);
688-
689-
if(ax.rangebreaks) { // this might be useful in general - but applying it only to rangebreaks for now
690-
if(label.text !== prevLabel) {
691-
ticksOut.push(label);
692-
}
693-
} else {
694-
ticksOut.push(label);
695-
}
696-
697-
prevLabel = label.text;
698680
}
699681

700682
ax._inCalcTicks = false;
Loading
Loading

0 commit comments

Comments
 (0)